Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(SPV-736) adding admin contacts methods #223

Merged
merged 7 commits into from
May 10, 2024
Merged

feat(SPV-736) adding admin contacts methods #223

merged 7 commits into from
May 10, 2024

Conversation

ac4ch
Copy link
Contributor

@ac4ch ac4ch commented May 8, 2024 •
edited
Loading

Pull Request Checklist

  • 📖 I created my PR using provided : CODE_STANDARDS
  • 📖 I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • ✅ I have provided tests for my changes.
  • 📝 I have used conventional commits.
  • 📗 I have updated any related documentation.
  • 💾 PR was issued based on the Github or Jira issue.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 8, 2024 •
edited
Loading

Manual Tests

💚 Manual testing by @chris-4chain resulted in success.

@ac4ch ac4ch marked this pull request as ready for review May 9, 2024 06:37
@ac4ch ac4ch requested a review from a team as a code owner May 9, 2024 06:37
@ac4ch ac4ch requested review from dorzepowski and chris-4chain May 9, 2024 10:27
chris-4chain
chris-4chain reviewed May 9, 2024
View reviewed changes
examples/http_admin/http_admin.go Outdated Show resolved Hide resolved
admin_contacts.go Show resolved Hide resolved
transports/http_admin.go Outdated Show resolved Hide resolved
@ac4ch ac4ch enabled auto-merge (squash) May 10, 2024 02:26
@ac4ch ac4ch disabled auto-merge May 10, 2024 02:37
@ac4ch ac4ch requested a review from chris-4chain May 10, 2024 05:32
dorzepowski
dorzepowski approved these changes May 10, 2024
View reviewed changes
transports/http_admin.go Show resolved Hide resolved
@chris-4chain
Copy link
Contributor

testing 🧪

@chris-4chain chris-4chain added the tested PR was tested by a team member label May 10, 2024
@ac4ch ac4ch merged commit 652747f into main May 10, 2024
9 checks passed
@ac4ch ac4ch deleted the sync-js-client-with-go-client branch May 10, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris-4chain chris-4chain chris-4chain approved these changes

@pawellewandowski98 pawellewandowski98 pawellewandowski98 approved these changes

@dorzepowski dorzepowski dorzepowski approved these changes

Assignees
No one assigned
Labels
tested PR was tested by a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ac4ch @chris-4chain @dorzepowski @pawellewandowski98